fix(@angular-devkit/build-angular): remove unactionable error overlay suggestion from Vite-based dev server #26171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clydin
added
state: blocked
target: rc
… suggestion from Vite-based dev server The Vite-based development server that is used with the esbuild-based builders (`application`/`browser-esbuild`) will show an error overlay when the application build encounters an error. This overlay previously provided a suggestion to edit the `vite.config.js` configuration file to disable the error overlay. Since Vite usage is encapsulated within the Angular CLI, this suggestion is unactionable and may lead to user confusion due to no Vite configuration file being present within the project nor would creating one have an effect on the build process.
alan-agius4
added
action: review
alan-agius4
force-pushed
the
esbuild/unactionable-error-overlay
branch
from
d7417e3
to
3364efa
Compare
alan-agius4
approved these changes
Oct 30, 2023
alan-agius4
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Vite-based development server that is used with the esbuild-based builders (
application/browser-esbuild)will show an error overlay when the application build encounters an error. This overlay previously provided a
suggestion to edit the
vite.config.jsconfiguration file to disable the error overlay. Since Vite usage isencapsulated within the Angular CLI, this suggestion is unactionable and may lead to user confusion due to
no Vite configuration file being present within the project nor would creating one have an effect on the build
process.